mk: Run tidy after tests in 'make check' #15516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy takes like forever to run.
bors
added a commit
that referenced
this pull request
Jul 8, 2014
Tidy takes like forever to run. How many times have I wished I didn't have to sit through tidy before seeing my tests fail?
|
what? Don't the tests take longer than tidy? I remember asking for us to move tidy to run before the tests so that I didn't have to re-run the tests after placating tidy. |
|
This ticket: #7085 is what I was thinking of, though its not clear to me when/if it was addressed, since #7085 does not have a PR associated with it and was closed as irrelevant back in February. (I guess what I am really asking is: should the buildbots be changed to run |
|
Travis runs tidy first, which I believe is more useful than running tidy first on |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
fix: diagnostics for 'while let' loop with label in condition fix rust-lang#15516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy takes like forever to run. How many times have I wished I didn't have to sit through tidy before seeing my tests fail?